Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for popover in nav bar and z-index on ControlledPopover #786

Merged
merged 3 commits into from
Sep 18, 2024

Conversation

mattias800
Copy link
Collaborator

  • Add zIndex and appendTo props to ControlledPopover.
  • NavBarPopoverButton now toggles the popover, so if the user clicks it when it is open, it closes.
  • NavBarButton now forwards ref, so that it works with Popover anchoring.

- NavBarPopoverButton now toggles the popover, so if the user clicks it when it is open, it closes.
- NavBarButton now forwards ref, so that it works with Popover anchoring.
@mattias800 mattias800 added bug Something isn't working patch Increment the patch version when merged labels Sep 18, 2024
Copy link

github-actions bot commented Sep 18, 2024

Size Change: 0 B

Total Size: 388 kB

ℹ️ View Unchanged
Filename Size
packages/calendar/dist/index.es.js 22.9 kB
packages/calendar/dist/index.js 19.1 kB
packages/core/dist/index.es.js 8.94 kB
packages/core/dist/index.js 6.97 kB
packages/elements/dist/index.es.js 105 kB
packages/elements/dist/index.js 102 kB
packages/filter/dist/index.es.js 3.68 kB
packages/filter/dist/index.js 3.02 kB
packages/forms/dist/index.es.js 9.15 kB
packages/forms/dist/index.js 8.23 kB
packages/grid-export/dist/index.es.js 1.89 kB
packages/grid-export/dist/index.js 1.79 kB
packages/grid/dist/index.es.js 24.5 kB
packages/grid/dist/index.js 20.3 kB
packages/input-mask/dist/index.es.js 728 B
packages/input-mask/dist/index.js 626 B
packages/modal/dist/index.es.js 6.71 kB
packages/modal/dist/index.js 6 kB
packages/panels/dist/index.es.js 6.9 kB
packages/panels/dist/index.js 5.99 kB
packages/redux/dist/index.es.js 2.98 kB
packages/redux/dist/index.js 2.62 kB
packages/select/dist/index.es.js 4.52 kB
packages/select/dist/index.js 3.84 kB
packages/theme/dist/index.es.js 2.03 kB
packages/theme/dist/index.js 2.07 kB
packages/tooltip/dist/index.es.js 2.98 kB
packages/tooltip/dist/index.js 2.43 kB

compressed-size-action

@mattias800 mattias800 merged commit 24feae2 into master Sep 18, 2024
6 checks passed
@mattias800 mattias800 deleted the feature/z-index-on-controlled-popover branch September 18, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working patch Increment the patch version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants