Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Click on modal scrollbar no longer closes modal #785

Merged
merged 2 commits into from
Sep 17, 2024

Conversation

mattias800
Copy link
Collaborator

  • Fix typo.
  • Click on scrollbars in modal was registered as click outside and closed the modal.
  • Scrollbars in modal caused the side of the modal to lose round corners.

Before

image

After

image

- Click on scrollbars in modal was registered as click outside and closed the modal.
- Scrollbars in modal caused the side of the modal to lose round corners.
@mattias800 mattias800 added bug Something isn't working patch Increment the patch version when merged labels Sep 16, 2024
Copy link

github-actions bot commented Sep 16, 2024

Size Change: 0 B

Total Size: 388 kB

ℹ️ View Unchanged
Filename Size
packages/calendar/dist/index.es.js 22.9 kB
packages/calendar/dist/index.js 19.1 kB
packages/core/dist/index.es.js 8.94 kB
packages/core/dist/index.js 6.97 kB
packages/elements/dist/index.es.js 105 kB
packages/elements/dist/index.js 102 kB
packages/filter/dist/index.es.js 3.68 kB
packages/filter/dist/index.js 3.02 kB
packages/forms/dist/index.es.js 9.15 kB
packages/forms/dist/index.js 8.23 kB
packages/grid-export/dist/index.es.js 1.89 kB
packages/grid-export/dist/index.js 1.79 kB
packages/grid/dist/index.es.js 24.5 kB
packages/grid/dist/index.js 20.3 kB
packages/input-mask/dist/index.es.js 728 B
packages/input-mask/dist/index.js 626 B
packages/modal/dist/index.es.js 6.71 kB
packages/modal/dist/index.js 6 kB
packages/panels/dist/index.es.js 6.85 kB
packages/panels/dist/index.js 5.95 kB
packages/redux/dist/index.es.js 2.98 kB
packages/redux/dist/index.js 2.62 kB
packages/select/dist/index.es.js 4.52 kB
packages/select/dist/index.js 3.84 kB
packages/theme/dist/index.es.js 2.03 kB
packages/theme/dist/index.js 2.07 kB
packages/tooltip/dist/index.es.js 2.95 kB
packages/tooltip/dist/index.js 2.41 kB

compressed-size-action

@mattias800 mattias800 merged commit 6344708 into master Sep 17, 2024
6 checks passed
@mattias800 mattias800 deleted the feature/click-modal-scrollbar-should-not-close branch September 17, 2024 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working patch Increment the patch version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants