Add support for more header rows #769
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnknoop
commented
Sep 3, 2024
| if (validationError) { | ||
| return <ErrorScreen text={validationError.message} />; | ||
| } | ||
|
|
||
| const showAdditionalHeaderRow = Object.values(config.columns).some( |
There was a problem hiding this comment.
This feels like a hack. Do you have an idea for a cleaner way?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues addressed in this pr:
Support for more header rows
They are now rendered as part of the
theadso that they stick when scrolling. It also means they are properly repeated at the top of each page when printing. (Although we seem to have other issues with printability of StandardTable: most of the rows are just blank, which I'm guessing is because of virtualization).A thought: perhaps we should also offer control over how the primary header row is rendered? It is a little weird that you can pass a render function for the second header row but not for the first.
Simplify code by making entire
theadstickyAdding more header rows caused me to have to keep track of the number of preceding rows in order to compute the proper vertical offset for the
topposition (thegetTopPositionfunction). But nowadays we can make the entiretheadelement sticky, so we don't need to set it on thethelements anymore. This gets rid of a bunch of javascript logic, and also makes it easier to have multiple header rows sticky, since we don't need to think about offset from preceding header row.