Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Click outside to close modal now only reacts to onMouseDown. #768

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

mattias800
Copy link
Collaborator

Use case

User presses mouse button inside modal, then moves pointer outside of modal and releases the mouse button. The click is registered as outside the modal and closes it. Not very nice!

Now it uses onMouseDown instead of onClick, which requires the mouse down event to come from outside of modal.

# Use case

User presses mouse button inside modal, then moves pointer outside of modal and releases the mouse button.
The click is registered as outside the modal and closes it. Not very nice!

Now it uses onMouseDown instead of onClick, which requires the mouse down event to come from outside of modal.
@mattias800 mattias800 added bug Something isn't working patch Increment the patch version when merged labels Aug 20, 2024
Copy link

Size Change: 0 B

Total Size: 380 kB

ℹ️ View Unchanged
Filename Size
packages/calendar/dist/index.es.js 22.3 kB
packages/calendar/dist/index.js 18.6 kB
packages/core/dist/index.es.js 8.87 kB
packages/core/dist/index.js 6.91 kB
packages/elements/dist/index.es.js 102 kB
packages/elements/dist/index.js 99.5 kB
packages/filter/dist/index.es.js 3.68 kB
packages/filter/dist/index.js 3.02 kB
packages/forms/dist/index.es.js 8.62 kB
packages/forms/dist/index.js 7.8 kB
packages/grid-export/dist/index.es.js 1.89 kB
packages/grid-export/dist/index.js 1.79 kB
packages/grid/dist/index.es.js 24.6 kB
packages/grid/dist/index.js 20.3 kB
packages/input-mask/dist/index.es.js 714 B
packages/input-mask/dist/index.js 615 B
packages/modal/dist/index.es.js 6.54 kB
packages/modal/dist/index.js 5.84 kB
packages/panels/dist/index.es.js 7.12 kB
packages/panels/dist/index.js 6.18 kB
packages/redux/dist/index.es.js 2.98 kB
packages/redux/dist/index.js 2.62 kB
packages/select/dist/index.es.js 4.52 kB
packages/select/dist/index.js 3.84 kB
packages/theme/dist/index.es.js 2.03 kB
packages/theme/dist/index.js 2.07 kB
packages/tooltip/dist/index.es.js 2.89 kB
packages/tooltip/dist/index.js 2.61 kB

compressed-size-action

@mattias800 mattias800 merged commit bd21a81 into master Aug 20, 2024
6 checks passed
@mattias800 mattias800 deleted the feature/close-modal-on-mouse-down branch August 20, 2024 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working patch Increment the patch version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants