Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add aiohttp and aiohttp-sse-client as optional dependencies. #765

Merged
merged 4 commits into from
Aug 27, 2023

Conversation

overcat
Copy link
Member

@overcat overcat commented Aug 27, 2023

No description provided.

@codecov
Copy link

codecov bot commented Aug 27, 2023

Codecov Report

Merging #765 (565fe4f) into soroban (f0b012d) will decrease coverage by 0.04%.
The diff coverage is 69.23%.

Impacted file tree graph

@@             Coverage Diff             @@
##           soroban     #765      +/-   ##
===========================================
- Coverage    98.68%   98.65%   -0.04%     
===========================================
  Files          248      248              
  Lines        12377    12385       +8     
===========================================
+ Hits         12214    12218       +4     
- Misses         163      167       +4     
Flag Coverage Δ
unittests 98.65% <69.23%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
stellar_sdk/client/aiohttp_client.py 89.62% <66.66%> (-2.38%) ⬇️
stellar_sdk/__init__.py 96.96% <75.00%> (-3.04%) ⬇️

@overcat overcat merged commit 4202abf into soroban Aug 27, 2023
26 of 45 checks passed
@overcat overcat deleted the 202308/optional-async branch August 27, 2023 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant