Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(argo-controller): parameterize argo workflows resource names #466

Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions stable/argo-controller/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,10 @@ type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: 0.0.10
version: 0.0.11

# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application. Versions are not expected to
# follow Semantic Versioning. They should reflect the version the application is using.
# It is recommended to use it with quotes.
appVersion: "0.0.1"
appVersion: "0.0.2"
3 changes: 3 additions & 0 deletions stable/argo-controller/templates/deployment-workflows.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,9 @@ spec:
imagePullPolicy: {{ .Values.image.pullPolicy }}
args:
- workflows
- -- namespace-admins-role-binding-name={{ required "workflows.args.namespaceAdminsRoleBindingName is required" .Values.workflows.args.namespaceAdminsRoleBindingName }}
- -- user-interface-cluster-role-name={{ required "workflows.args.userInterfaceClusterRoleName is required" .Values.workflows.args.userInterfaceClusterRoleName }}
- -- argo-workflows-cluster-role-name={{ required "workflows.args.argoWorkflowsClusterRoleName is required" .Values.workflows.args.argoWorkflowsClusterRoleName }}
env:
{{- if .Values.storageAccount.existingSecret }}
- name: ARGO_SECRET_NAME
Expand Down
6 changes: 6 additions & 0 deletions stable/argo-controller/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -62,3 +62,9 @@ serviceAccount:
# The name of the service account to use.
# If not set and create is true, a name is generated using the fullname template
name: ""

workflows:
args:
namespaceAdminsRoleBindingName: "solution-builder"
userInterfaceClusterRoleName:
argoWorkflowsClusterRoleName:
frazs marked this conversation as resolved.
Show resolved Hide resolved
Loading