Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(sidecar-terminator): Sync with improvements from 1.3.0 #459

Merged
merged 2 commits into from
Nov 30, 2023
Merged

feat(sidecar-terminator): Sync with improvements from 1.3.0 #459

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
99c0c87
feat(sidecar-terminator): Sync with improvements from 1.3.0
sylus Nov 30, 2023
85648ee
feat(sidecar-terminator): Sync with improvements from 1.3.0
statcan-svc Nov 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions stable/sidecar-terminator/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,13 @@ appVersion: "1.0.0"
description: |-
A chart used for easily configuring kubernetes-sidecar-terminator in a cluster.
name: sidecar-terminator
version: 1.2.1
version: 1.2.2
keywords:
- sidecar-terminator
sources:
- https://gitlab.k8s.cloud.statcan.ca/cloudnative/terraform/modules/terraform-kubernetes-sidecar-terminator
- https://github.com/statcan/kubernetes-sidecar-terminator
maintainers:
- name: Mohamed Dahrouj
email: [email protected]
home: https://www.statcan.gc.ca
kubeVersion: ">= 1.23"
11 changes: 9 additions & 2 deletions stable/sidecar-terminator/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,15 @@ apiVersion: apps/v1
kind: Deployment
metadata:
name: {{ include "sidecar-terminator.fullname" . }}
{{- with .Values.podAnnotations }}
annotations:
{{- toYaml . | nindent 8 }}
{{- end }}
labels:
{{- include "sidecar-terminator.labels" . | nindent 4 }}
{{- include "sidecar-terminator.labels" . | nindent 8 }}
{{- with .Values.podLabels }}
{{- toYaml . | nindent 8 }}
sylus marked this conversation as resolved.
Show resolved Hide resolved
{{- end }}
spec:
replicas: {{ .Values.replicaCount }}
selector:
Expand All @@ -24,7 +31,7 @@ spec:
priorityClassName: {{ .Values.priorityClassName }}
{{- end }}
containers:
- image: {{ .Values.image.repository }}
- image: "{{ .Values.image.repository }}:{{ .Values.image.tag | default .Chart.AppVersion }}"
name: sidecar-terminator
args:
- '--lock-namespace'
Expand Down
7 changes: 6 additions & 1 deletion stable/sidecar-terminator/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,13 @@

replicaCount: 1

# Annotations to add to the Pod
podAnnotations: {}
# Labels to add to the Pod
podLabels: {}

image:
repository: zachomedia/kubernetes-sidecar-terminator
repository: statcan/kubernetes-sidecar-terminator
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we have a image for it at statcan/kubernetes-sidecar-terminator for v1.0.0

pullPolicy: IfNotPresent
# Overrides the image tag whose default is the chart appVersion.
tag: ""
Expand Down
Loading