Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update(fdi-dotstatsuite): deploy yaml files bash to sh #448

Merged
merged 2 commits into from
Nov 27, 2023

Conversation

yuhangwongstatcan
Copy link
Contributor

update deploy six yaml files bash to sh

MichaelPatsula
MichaelPatsula previously approved these changes Nov 21, 2023
Copy link
Contributor

@MichaelPatsula MichaelPatsula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like you forgot to increment the chart version within the Chart.yaml file. I would recommend updating it before merging it in.

Other then that. It LGTM!

@MichaelPatsula MichaelPatsula changed the title update deploy yaml files bash to sh update(fdi-dotstatsuite): deploy yaml files bash to sh Nov 27, 2023
@MichaelPatsula MichaelPatsula merged commit 29dd3bd into StatCan:master Nov 27, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants