Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sticky sidebar #323

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

sticky sidebar #323

wants to merge 1 commit into from

Conversation

Roman991
Copy link

in height responsive sidebar

@Roman991 Roman991 requested a review from davidtmiller January 26, 2020 11:06
@tiesont
Copy link

tiesont commented Jan 26, 2020

Pretty sure this can be accomplished just by adding the sticky-top class from Bootstrap. This also assumes everyone wants a sticky sidebar, which isn't likely.

@Roman991
Copy link
Author

Roman991 commented Jan 27, 2020

Pretty sure this can be accomplished just by adding the sticky-top class from Bootstrap.

this is a more complete implementation, because it also fits in height the content of sidebar and brings popovers to the foreground.

This also assumes everyone wants a sticky sidebar, which isn't likely.

the space occupied onscreen is always the same, so why on scrolling I should prefer an empty sidebar?

@tiesont
Copy link

tiesont commented Jan 27, 2020

@Roman991 "so why on scrolling I should prefer" - well, you're requesting to make changes to a public template, which then assumes everyone who uses it wants a sticky sidebar. That's a design decision for each person who uses this template to make.

Now, if you added your updates to a separate rule, which implementers could choose to add, that would be useful / more flexible.

Obviously, just my two cents, but I'm doubting this gets pulled in.

@GGI1982
Copy link

GGI1982 commented Sep 25, 2020

That's a design decision 👎

The whole theme is a design decision and @Roman991 is right 👍 when he says :

the space occupied onscreen is always the same, so why on scrolling I should prefer an empty sidebar?

Copy link

@alisamadiii alisamadiii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed your codes, and Your codes look clean and clear.
Wish you all the best.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants