Rewrite particle modifier demo #779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, research friend! 👋 |
for more information, see https://pre-commit.ci
|
Hi, research friend! 👋 |
cgokmen
reviewed
Jul 18, 2024
omnigibson/examples/object_states/particle_applier_remover_demo.py
Outdated
Show resolved
Hide resolved
…tanfordVL/OmniGibson into rewrite-particle-modifier-demo
for more information, see https://pre-commit.ci
|
This particle demo is finished |
…into rewrite-particle-modifier-demo
hang-yin
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the modifier is rewritten, with the following particles:
salt, water
salt projection particle remover: vacuum-wikhik
salt adjacency particle remover: dishtowel-dtfspn
salt projection particle applier: salt_shaker-iomwtn
water adjacency particle remover: dishtowel-dtfspn
water projection particle applier: water_atomizer-lfarai
*Note that there are no salt adjacency particle applier, water adjacency particle applier, or water projection particle remover