Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor tools/launchdev.sh to use tmux #6186

Merged
merged 15 commits into from
Apr 23, 2024
Merged

Refactor tools/launchdev.sh to use tmux #6186

merged 15 commits into from
Apr 23, 2024

Conversation

cognifloyd
Copy link
Member

@cognifloyd cognifloyd commented Apr 19, 2024

This is primarily work by @nzlosh who figured out how to replace screen with tmux in #6157. On top of that, I:

  • reverted a port change in launchdev.sh that looks like copy pasta,
  • added a sleep to avoid polluting so many logs with "mongo document already exists" errors as st2 processes started nearly in parallel and then attempt to initialize the database in parallel,
  • refactored a few messages in launchdev.sh,
  • finished cleaning up some other files to finish removing screen, and
  • adjusted logs capture in GitHub Actions to be more reliable and to prevent one test from overwriting the logs of other tests.

Some of my changes were extracted from #6130.

@cognifloyd cognifloyd added this to the 3.9.0 milestone Apr 19, 2024
@cognifloyd cognifloyd self-assigned this Apr 19, 2024
@cognifloyd cognifloyd requested review from amanda11, nzlosh, winem and a team April 19, 2024 06:38
@pull-request-size pull-request-size bot added the size/L PR that changes 100-499 lines. Requires some effort to review. label Apr 19, 2024
@cognifloyd cognifloyd requested a review from a team April 19, 2024 08:14
@cognifloyd cognifloyd merged commit 96ce1d7 into master Apr 23, 2024
28 of 29 checks passed
@cognifloyd cognifloyd deleted the launchdev-refactor branch April 23, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure: ci/cd refactor size/L PR that changes 100-499 lines. Requires some effort to review. tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants