Split out zstandard compression (split from #5995) #6121
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull-request-size
bot
added
the
size/XL
|
The history should not be deleted so we can preserve the git blame in the future, imo. |
|
Also, thanks, I know this is a lot of work. |
|
@guzzijones by that do you mean you'd rather me fork from your repo/branch and then add a commit removing the liveaction id change? If so I can look at tackling that this week. |
|
yes please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
splitting out the zstandard work done by @guzzijones in #5995
If we would rather just have the original PR go through, lmk and I can close this. But I saw a comment on his PR that it'd be nice to split the two out.
All credit for work on this goes to @guzzijones , I'm splitting it out with the hope of moving it through so we can mitigate the document size errors.