Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Remove incorrect PUTFIELD owner check when inspecting initialisers. #672

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix: Remove incorrect PUTFIELD owner check when inspecting initialisers. #672

wants to merge 1 commit into from

Commits on Jul 13, 2024

  1. Fix: Remove incorrect PUTFIELD owner check when inspecting initiali… 

    …sers.

These will never match because the LHS is the mixin name and the RHS is the target name.
This restores the 0.8.5 behaviour which does not check the owner at all.
We have never supported assignment expressions in initialisers until now anyway, and even if we check the owner we cannot determine whether the instruction is operating on the current *instance* without proper static analysis, so IMO there's not much point bothering.
    @LlamaLad7
    LlamaLad7 committed Jul 13, 2024
    Configuration menu
    Copy the full SHA
    46500fe View commit details
    Browse the repository at this point in the history