Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tauri v2 (for real this time probably) #246

Merged
merged 75 commits into from
Sep 5, 2024
Merged

Tauri v2 (for real this time probably) #246

merged 75 commits into from
Sep 5, 2024

Conversation

SpikeHD
Copy link
Owner

@SpikeHD SpikeHD commented Jul 10, 2024

Porting to Tauri v2

@SpikeHD
Copy link
Owner Author

SpikeHD commented Jul 10, 2024

Awesome progress

image

@SpikeHD
Copy link
Owner Author

SpikeHD commented Jul 10, 2024

This is apparently due to the preinject script. Assuming I can get that working this actually doesn't seem too difficult

@SpikeHD
Copy link
Owner Author

SpikeHD commented Jul 12, 2024

Some discoveries related specifically to Windows:

  • Replacing inbuilt window properties (e.g fetch or XMLHttpRequest) causes STATUS_ACCESS_VIOLATION when done too early, and I suspect Tauri v2's initialization_script runs earlier than v1. These were moved to a later part of the loading process.
  • tauri-plugin-http hangs when sending requests for some reason. Does not throw an error, even if URL is something nonsensical like __TAURI__.http.fetch('test').
  • load_plugins command hangs when invoked in the frontend. It is not an infinite loop and the function does exit, so idk what's going on there.

TODO see if this happens on Linux too.

@SpikeHD
Copy link
Owner Author

SpikeHD commented Jul 14, 2024

Regarding the above ^

Tauri commands that return primitive values (string, number, bool, etc.) all work fine. Commands that return complex values, like HashMaps or other structs, will infinitely hang. I have not observed higher CPU usage or anything weird. The reason the HTTP module hangs is for the same reason - it returns a complex object here. I have no idea where this issue resides and it's driving me insane.

Can also confirm that this happens on Linux too, so it's definitely an internal Tauri IPC issue

@Banaanae
Copy link

Hey spike, not sure if you want bug reports with this yet, but here are my observations while running windows 11.
After installing i also got STATUS_ACCESS_VIOLATION, but pressing refresh fixed.
I can't send messages (this is in your server, dms dont work either)
image
(never seen that message in a public server 👀)
image
image
It seems all the api stuff is a bit whack
Last issue i found (as it's very hard to find an issue when nothing works) is with the tray icon
image
The button with the icon focuses dorion when left clicked, but does nothing when right-clicked
The button with no icon (left of dorion icon) does nothing when left clicked, but shows Open|Reload|Restart|Quit menu when right clicked)

If you need anymore testing I have both windows 11 and debian to test on

@Banaanae
Copy link

Clicking the add reaction button causes this
image
Reactions still work

@SpikeHD
Copy link
Owner Author

SpikeHD commented Jul 20, 2024

That's fine those warnings are everywhere (and happen in current Dorion too, probably), they don't seem to mean anything

@SpikeHD
Copy link
Owner Author

SpikeHD commented Jul 20, 2024

Also yes that spam of errors is (likely) due to the issues I've outlined above, this branch is very much not finished yet

@SpikeHD
Copy link
Owner Author

SpikeHD commented Jul 31, 2024

Related: tauri-apps/tauri#10327

@SpikeHD SpikeHD merged commit 0fe9067 into main Sep 5, 2024
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants