Introduce separate extended tests in CI #628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maximilian-gelbrecht
added
the
testing 🧪
milankl
reviewed
Dec 3, 2024
There was a problem hiding this comment.
Happy with this but it would always run extended tests on nightly not on the currently supported version like 1.10 or 1.11 atm, is that what we would want? Alternatively, we could create .github/workflows/extended_tests.yml but run with current minor release independent of the nightly workflow?
|
Yes, that's a good point. I'll add that tomorrow. |
|
Ok, that should be ready to go now. I'll merge it later today if you don't object |
milankl
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces a flag
FLAG_EXTENDED_TESTSin the tests that mark tests that are not run in the regular CI, but only in the weekly CI.The first tests that went into this category are the more high-level differentiability tests. The low-level
test_reversefromEnzymeTestUtilsare staying in the main tests.