Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SpeedyTransforms] Restrict finite difference tests to one grid only #625

Merged
merged 4 commits into from
Dec 2, 2024

Conversation

maximilian-gelbrecht
Copy link
Member

The AD finite differences test take quite a while in the CI, this does those just for one grid type. For the other grid the transform identity is still tested.

@maximilian-gelbrecht maximilian-gelbrecht added testing 🧪 How we test things and continuous integration transform ⬅️ ➡️ Our spherical harmonic transform, grid to spectral, spectral to grid differentiability 🤖 Making the model differentiable via AD labels Dec 2, 2024
@maximilian-gelbrecht maximilian-gelbrecht merged commit f943780 into main Dec 2, 2024
5 checks passed
@milankl
Copy link
Member

milankl commented Dec 2, 2024

reminder to squash merge 😉 Otherwise the number of commits in this repo is increasing too quickly which increases the repo size ... but tbh I've never figured out why the repo size is 200MB?

image

@maximilian-gelbrecht
Copy link
Member Author

We could remove all the old branches and run the git gc

@milankl
Copy link
Member

milankl commented Dec 2, 2024

yes, feel free to delete your old branches, I don't want delete yours though!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
differentiability 🤖 Making the model differentiable via AD testing 🧪 How we test things and continuous integration transform ⬅️ ➡️ Our spherical harmonic transform, grid to spectral, spectral to grid
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants