Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust OutputWriter to new structure #571

Closed
wants to merge 2 commits into from

Conversation

maximilian-gelbrecht
Copy link
Member

@maximilian-gelbrecht maximilian-gelbrecht commented Aug 14, 2024

While our HPC is still offline / making problems, I had some time revise the OutputWrite according to the new structure. This isn't the complete overhaul suggested in #522, it just revises the current code. I might make an attempt at #522 later if the problems with our HPC continue to persist.

This doesn't fully work yet because of #570

But as soon as this issue is resolved, this could be merged into the PR #525

@maximilian-gelbrecht maximilian-gelbrecht added structure 🏠 Internal structure of the code output 📤 NetCDF or JLD2 output, their writers, formats, etc labels Aug 14, 2024
@milankl
Copy link
Member

milankl commented Aug 14, 2024

That's great. I have started to make the output writer modular but I forgot to commit the changes before leaving for Scotland. Those changes should address everything for #522 but I'll be able to push these in 10 days... sorry!

@milankl
Copy link
Member

milankl commented Aug 28, 2024

@maximilian-gelbrecht you think this is superceded by #573 ?

@maximilian-gelbrecht
Copy link
Member Author

Yes, not needed anymore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
output 📤 NetCDF or JLD2 output, their writers, formats, etc structure 🏠 Internal structure of the code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants