Fix RingGrid broadcast issue with mismatching dimensions #568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maximilian-gelbrecht
added
bug 🐞
milankl
approved these changes
Aug 1, 2024
|
Very happy with that, not that we'd really need 5D+ variables, and if that's the case one can either be explicit with the broadcasting or we can then still address this issue... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #565
Just needed a look into the Julia docs to figure it out.
Unfortunately the solution is a bit "ugly" and not completely general as Julia doesn't allow any arithmetics with type parameters (e.g.
Grid{N+1}) doesn't work