Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add space after comma #473

Merged
merged 7 commits into from
Mar 6, 2024
Merged

Add space after comma #473

merged 7 commits into from
Mar 6, 2024

Conversation

navidcy
Copy link
Collaborator

@navidcy navidcy commented Mar 6, 2024

@milankl what do you think?
Feel free to close!

@navidcy navidcy requested a review from milankl March 6, 2024 11:40
@navidcy navidcy added the style 💄 Coding but in style label Mar 6, 2024
@milankl
Copy link
Member

milankl commented Mar 6, 2024

No I love it, I've always been on the more relaxed side of linting, but adding commas is definitely nice for code. However, I also see that it's affecting the markdown files, where when displayed code I again agree, but when displaying maths not always. E.g. the mathematical range I'd write like $[0,1]$ not $[0, 1]$. Ha pitfall of mine, I realised that this still gets rendered the same even though I wrote [0,1] and [0, 1]. Neat. Then I approve.

@navidcy
Copy link
Collaborator Author

navidcy commented Mar 6, 2024

LaTeX puts the space whether you like it or not ;)

@navidcy navidcy merged commit 4a0ebb3 into main Mar 6, 2024
3 checks passed
@navidcy navidcy deleted the ncc/space-after-comma branch March 6, 2024 21:10
@navidcy navidcy mentioned this pull request Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
style 💄 Coding but in style
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants