Redo 5.6.2 release #621
Merged
Redo 5.6.2 release #621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackson 2.15.x pulls in a dependency that is not compatible with Java 8, and this causes the shadowJar task to fail.
|
Also, make sure the shadowJar task is run as part of the testing process so that we can catch dependencies that drop Java 8 support in the future. |
scribe
approved these changes
Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jackson 2.15.x brings in a dependency that is not compatible with Java 8, and the shadowJar task fails. We will be stuck on Jackson 2.14.x until we move on from Java 8 support.