Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some work with a profiler detected a handful of issues:
Arrays.asList(new String[] {}
withCollections.emptyList()
to avoid unnecessary allocationsnew Function<…>
with static classes to allow the GC to run correctlyArrays.asList
withList.of
which should bound allocationCharset.forName("UTF-8")
which requires a parser withStandardCharsets.UTF_8
which does not.All of these together have left the profiler graphs in significantly better shape.
Edit: I ran tests on my laptop but I really want to see the tests run in Jenkins to give me better feelings.