Persist HasMany Relations #4191
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickbrouwers
requested changes
Sep 4, 2024
| @@ -98,7 +99,7 @@ private function persistBelongsTo(BelongsTo $relation, array $models): bool | |||
| * @param array $models | |||
| * @return bool | |||
| */ | |||
| private function persistBelongsToMany(BelongsToMany $relation, array $models): bool | |||
| private function persistToMany(BelongsToMany|HasMany $relation, array $models): bool | |||
There was a problem hiding this comment.
This doesn't work on older PHP versions which we currently still support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please take note of our contributing guidelines: https://docs.laravel-excel.com/3.1/getting-started/contributing.html
Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
1️⃣ Why should it be added? What are the benefits of this change?
2️⃣ Does it contain multiple, unrelated changes? Please separate the PRs out.
3️⃣ Does it include tests, if possible?
4️⃣ Any drawbacks? Possible breaking changes?
5️⃣ Mark the following tasks as done:
6️⃣ Thanks for contributing! 🙌