Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mainframe: use https #274

Merged
merged 1 commit into from
Dec 16, 2024
Merged

mainframe: use https #274

merged 1 commit into from
Dec 16, 2024

Conversation

sre
Copy link
Contributor

@sre sre commented Dec 15, 2024

While the mainframe status SpaceApi is accessible via unencrypted http connections, we recommend using https when possible.

@sre
mainframe: use https
cae5665 
While the mainframe status SpaceApi is accessible via unencrypted
http connections, we recommend using https when possible.
rnestler
rnestler approved these changes Dec 16, 2024
View reviewed changes
Copy link
Member

@rnestler rnestler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. You could add v14 compatibility by just adding "api_compatibility": ["14"], as a top-level key since your endpoint seems already v14 compatible. See also

@rnestler rnestler merged commit 1f90216 into SpaceApi:master Dec 16, 2024
1 check passed
@sre sre mentioned this pull request Dec 16, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rnestler rnestler rnestler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sre @rnestler