Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update LeineLab endpoint #272

Merged
merged 1 commit into from
Dec 4, 2024
Merged

Update LeineLab endpoint #272

merged 1 commit into from
Dec 4, 2024

Conversation

soundstorm
Copy link
Contributor

No description provided.

Copy link
Member

@rnestler rnestler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The old endpoint seems to redirect to the new one, so this looks fine. Anyway: The content you return has errors: https://validator.spaceapi.io/ui/?url=https://leinelab.org/api/spaceapi.json

@soundstorm
Copy link
Contributor Author

Should be fixed by now :)
The temperature field was correct once upon a time, but seems the update script replaced the whole array element instead of the value :)

Copy link
Member

@rnestler rnestler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was fast 🙂 even the CORS issues seem fixed, awesome 🎉

@rnestler rnestler merged commit a1b16db into SpaceApi:master Dec 4, 2024
1 check passed
@soundstorm
Copy link
Contributor Author

Sure 😇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants