Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SpaceAPI endpoint of FabLab Karlsruhe #271

Merged
merged 2 commits into from
Nov 15, 2024
Merged

Add SpaceAPI endpoint of FabLab Karlsruhe #271

merged 2 commits into from
Nov 15, 2024

Conversation

maufl
Copy link
Contributor

@maufl maufl commented Nov 15, 2024

We recently created a SpaceAPI endpoint for our maker space :)
https://spaceapi.fablab-karlsruhe.de/

rnestler
rnestler approved these changes Nov 15, 2024
View reviewed changes
Copy link
Member

@rnestler rnestler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good. SpaceAPI validator is happy: https://validator.spaceapi.io/ui/?url=https://spaceapi.fablab-karlsruhe.de/

@rnestler rnestler merged commit aeda035 into SpaceApi:master Nov 15, 2024
1 check passed
@rnestler
Copy link
Member

But note that you use space: "FabLab Karlsruhe" in the JSON, but "FabLab Karlsruhe e.V." in the index. These two should be equal.

@hlfbt
Copy link

hlfbt commented Nov 17, 2024

You're right, I've fixed the API to correctly return FabLab Karlsruhe e.V. as well. Thank you for the heads up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rnestler rnestler rnestler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maufl @rnestler @hlfbt