Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated hackerspace.gent json location #268

Merged
merged 3 commits into from
Nov 10, 2024
Merged

Updated hackerspace.gent json location #268

merged 3 commits into from
Nov 10, 2024

Conversation

mrosseel
Copy link
Contributor

@mrosseel mrosseel commented Nov 8, 2024

No description provided.

@s3lph
Copy link
Contributor

s3lph commented Nov 8, 2024

Hi @mrosseel, thanks for updating the endpoint. One small thing: It appears your new endpoint does not set a CORS header. Ideally, the header Access-Control-Allow-Origin: * would be set by your webserver, so that your endpoint can be queried from web-based clients.

Is it possible for you to set this header? Thanks!

@mrosseel
Copy link
Contributor Author

mrosseel commented Nov 9, 2024 •
edited
Loading

hi, thx for the heads up, I've added the header on the result from the webserver

s3lph
s3lph approved these changes Nov 10, 2024
View reviewed changes
Copy link
Contributor

@s3lph s3lph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update, looks good now.

@s3lph s3lph merged commit 7d06e8c into SpaceApi:master Nov 10, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@s3lph s3lph s3lph approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mrosseel @s3lph