Add Hal9k. #267
Merged
Add Hal9k. #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbrgn
approved these changes
Nov 2, 2024
There was a problem hiding this comment.
Hi, thanks for your submission!
The endpoint looks good for inclusion, but two notes about the content of your endpoint:
- The
"api": "0.14"field is not valid. That is an old format that was used up to and including version 0.13, but version 14 of the API will simply ignore it. You can remove that line. - The logo and website URLs are specified with
http://, even thoughhttps://would work as well
We recommend fixing those two issues. Nevertheless, this is good to merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.