Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hacKNology e.V. to directory #266

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

xperimental
Copy link
Contributor

@xperimental xperimental commented Oct 6, 2024

This adds "hacKNology e.V." to the directory. It is a hackerspace in Konstanz, Germany.

Copy link
Member

@rnestler rnestler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me and validator approves: https://validator.spaceapi.io/ui/?url=https://www.hacknology.de/spaceapi/status.json

You could consider adding v14 support. See https://spaceapi.io/ for an example that is both v0.13 and v14 compatible.

@xperimental
Copy link
Contributor Author

Sorry for the slow reply. I planned to look into updating our API to v14 yesterday but did not get to it yet.

I already had a look at a diff of the two schemas and if I'm not missing anything, then I think the thing missing is the attribute announcing the compatibility and some new attributes about new social network services (the only relevant one I've seen is Mastodon).

Is the change to v14 required for getting this PR merged?

@rnestler
Copy link
Member

rnestler commented Oct 9, 2024

I already had a look at a diff of the two schemas and if I'm not missing anything, then I think the thing missing is the attribute announcing the compatibility

I think just adding "api_compatibility": ["14"], should be enough in your case.

Is the change to v14 required for getting this PR merged?

No, I can merge it now.

@rnestler rnestler merged commit 1af7d5e into SpaceApi:master Oct 9, 2024
1 check passed
@xperimental xperimental deleted the add-hacknology branch October 9, 2024 16:39
@xperimental
Copy link
Contributor Author

@rnestler Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants