Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added extension #1

Merged
merged 6 commits into from
Feb 24, 2024
Merged

Added extension #1

merged 6 commits into from
Feb 24, 2024

Conversation

FoxWorn3365
Copy link
Contributor

The coconut nut is a giant nut
If you eat too much, you'll get very fat
Now, the coconut nut is a big, big nut
But this delicious nut is not a nut
It's the coco fruit (it's the coco fruit)
Of the coco tree (of the coco tree)
From the coco palm family
There are so many uses of the coconut tree
You can build a big house for the family
All you need is to find a coconut man
If he cuts the tree, he gets the fruit free
It's the coco fruit (it's the coco fruit)
Of the coco tree (of the coco tree)
From the coco palm family
The coconut bark for the kitchen floor
If you save some of it, you can build a door
Now, the coconut trunk, do not throw this junk
If you save some of it, you'll have the second floor
The coconut wood is very good
It can stand 20 years if you pray it would
Now, the coconut root, to tell you the truth
You can throw it or use it as firewood
The coconut leaves, good shade it gives
For the roof, for the walls up against the eaves
Now, the coconut fruit, say my relatives
Make good cannonballs up against the eaves
It's the coco fruit (it's the coco fruit)
Of the coco tree (of the coco tree)
From the coco palm family
The coconut nut is a giant nut
If you eat too much, you'll get very fat
Now, the coconut nut is a big, big nut
But this delicious nut is not a nut
It's the coco fruit (it's the coco fruit)
Of the coco tree (of the coco tree)
From the coco palm family
It's the coco fruit (it's the coco fruit)
Of the coco tree (of the coco tree)
From the coco palm family
It's the coco fruit (it's the coco fruit)
Of the coco tree (of the coco tree)
From the coco palm family

@SpGerg
Copy link
Owner

SpGerg commented Feb 9, 2024

Conflicts

@SpGerg
Copy link
Owner

SpGerg commented Feb 9, 2024

Why directive is IStatement

@FoxWorn3365
Copy link
Contributor Author

Where?

@SpGerg
Copy link
Owner

SpGerg commented Feb 9, 2024

Where?

Directive expression

@FoxWorn3365
Copy link
Contributor Author

Because an IStatement is needed

Copy link
Owner

@SpGerg SpGerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, can you doc methods and classes.

Paganism/API/ImportManager.cs Outdated Show resolved Hide resolved
Paganism/Exceptions/ExtensionException.cs Outdated Show resolved Hide resolved
Paganism/Exceptions/ExtensionException.cs Outdated Show resolved Hide resolved
Paganism/Interpreter/Data/Extensions/Extension.cs Outdated Show resolved Hide resolved
Paganism/Interpreter/Data/Extensions/Extension.cs Outdated Show resolved Hide resolved
new Argument("content", TypesType.String)
}, false, true), (Argument[] arguments) =>
{
Console.WriteLine(arguments[0].Value.Eval().AsString());
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Console WriteLine

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bro but this is the Print function

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is functions must be in std

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not in the language

@@ -28,6 +30,7 @@ public Parser(Token[] tokens, string filePath)
public bool InLoop { get; private set; }

public string Filepath { get; private set; }
public string _ExtensionFunction { get; private set; } = string.Empty;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What problem with field name

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

_Ext...
Why _?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to separate the name from the other common names and yeah should be internal

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fields can start with '_' only if it is private

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in other ways using '_' it is wrong

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So also return public

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should not be public becauseof it's nature and use, let's remove the _ but keep it internal

@SpGerg SpGerg merged commit b3a7386 into main Feb 24, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants