-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/login #16
Open
11t518s
wants to merge
30
commits into
develop
Choose a base branch
from
feature/login
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Feature/login #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
로그인 화면 초기화, input form 생성, CSS 적용 #14
전환되는 component 작업 #14
미누스 테스트 커밋 #14
주석만 적고 테스트 커밋해보기 #14
주석제거하고 소스트리 다시 테스트 #14
로그인 화면 CSS 수정 #14
로그인상태값에 따라 인풋폼과 화면이동버튼 컨포넌트 전환 #14
로그인 상태 값에 따라 input form과 버튼 컴포넌트 전환 테스트 #14
로그인 화면에서 컴포넌트를 전환시키는 전체적인 짜임 구성 #14
깃 충돌 수정 #14
map 기본구조 구성 #15
'Go'를 제외한 컴포넌트 전환 수정, CSS 수정, 태그 구조 수정 #14
11t518s
commented
Aug 25, 2022
pages/login/index.js
Outdated
<a className={styles.inputrequest}>Input your code number..</a>{" "} | ||
<br /> | ||
<input | ||
name="student-id" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
네이밍 컨벤션이 저희는 카멜 케이스로 하고 있으니 studentId로 해주시면 좋겠습니다!
로그인 뷰 로직 완성 #14
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
최근 작업 주제 (하나 이상의 주제를 선택해주세요.)
구현 사항
구현한 것에 대해 설명해주세요.
사진이나 동영상을 함께 첨부해주면 좋습니다!
기타
혹시 개발 하면서 조금 문제가 있는 것이 있었다면 써주고, 궁금한 것이나, 코드를 볼 때 참고해야하는 것이 있으면 적어주세요!