SONARJAVA-4462 Add quickfix support for S6485 #4461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
SonarQube Quality Gate
|
johann-beleites-sonarsource
force-pushed
the
db/SONARJAVA-4462
branch
from
7093a23
to
dd10ada
Compare
|
dorian-burihabwa-sonarsource
force-pushed
the
db/SONARJAVA-4462
branch
from
dd10ada
to
4922e8d
Compare
dorian-burihabwa-sonarsource
force-pushed
the
db/SONARJAVA-4462
branch
from
4922e8d
to
8a82049
Compare
leonardo-pilastri-sonarsource
requested changes
Sep 30, 2024
|
|
||
| import static org.sonar.java.checks.verifier.TestUtils.mainCodeSourcesPath; | ||
|
|
||
| class KnownCapacityHashBasedCollectionCheckTest { | ||
|
|
||
| @Test | ||
| void test() { | ||
| CheckVerifier.newVerifier() | ||
| InternalCheckVerifier.newInstance() |
There was a problem hiding this comment.
I realize now that it is misleading having 2 different types of verifier, and one of them as a .withQuickFixes method, but actually the CheckVerifier.newVerifier() that was there before was already checking quickfixes since we introduced the analyzer-commons-api underneath, so you can undo these changes here
| .forRule(this) | ||
| .onTree(newClassTree) | ||
| .withMessage(getIssueMessage(newClassTree)) | ||
| .withQuickFixes(() -> computeQuickFix(newClassTree)) |
There was a problem hiding this comment.
Here we can use the singular api withQuickFix since we always provide only one
Comment on lines
80
to
87
| private static List<JavaQuickFix> computeQuickFix(NewClassTree newClassTree) { | ||
| String replacementMethod = TYPES_TO_METHODS.get(newClassTree.symbolType().name()).replace("(int numMappings)", ""); | ||
| JavaTextEdit edit = JavaTextEdit.replaceBetweenTree(newClassTree.firstToken(), newClassTree.identifier().lastToken(), replacementMethod); | ||
| JavaQuickFix quickFix = JavaQuickFix.newQuickFix("Replace with \"" + replacementMethod + "\".") | ||
| .addTextEdit(edit) | ||
| .build(); | ||
| return List.of(quickFix); | ||
| } |
There was a problem hiding this comment.
This can be simplified to return 1 quickfix
Suggested change
| private static List<JavaQuickFix> computeQuickFix(NewClassTree newClassTree) { | |
| String replacementMethod = TYPES_TO_METHODS.get(newClassTree.symbolType().name()).replace("(int numMappings)", ""); | |
| JavaTextEdit edit = JavaTextEdit.replaceBetweenTree(newClassTree.firstToken(), newClassTree.identifier().lastToken(), replacementMethod); | |
| JavaQuickFix quickFix = JavaQuickFix.newQuickFix("Replace with \"" + replacementMethod + "\".") | |
| .addTextEdit(edit) | |
| .build(); | |
| return List.of(quickFix); | |
| } | |
| private static JavaQuickFix computeQuickFix(NewClassTree newClassTree) { | |
| String replacementMethod = TYPES_TO_METHODS.get(newClassTree.symbolType().name()).replace("(int numMappings)", ""); | |
| JavaTextEdit edit = JavaTextEdit.replaceBetweenTree(newClassTree.firstToken(), newClassTree.identifier().lastToken(), replacementMethod); | |
| return JavaQuickFix.newQuickFix("Replace with \"" + replacementMethod + "\".") | |
| .addTextEdit(edit) | |
| .build(); | |
| } |
* Use the right type of checkverifier * Set singular quickfix with matching reporting method * Remove ambiguous test with missing Java version
dorian-burihabwa-sonarsource
force-pushed
the
db/SONARJAVA-4462
branch
from
2bf468c
to
cfbe793
Compare
|
leonardo-pilastri-sonarsource
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.