Fix flatpak build #7283
Merged
Fix flatpak build #7283
+194
−163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any chance that this can also include a deployment stage to flathub? https://github.com/flatpak/flatpak-github-actions?tab=readme-ov-file#deployment-stage |
I don't think that flathub accepts external uploads. See #3949 for details |
|
I built a flatpak using this PR successfully, thanks! However, I noticed that you missed deleting this line: |
* Patch wxWidgets to automatically select dark theme variant (taken from Bambu slicer flatpak manifest) * Drop python script that selected dark theme * Add a patch to fix libslic3r build
anarsoul
force-pushed
the
flatpak-fixes
branch
from
3ff2dec
to
731a93e
Compare
Thanks, fixed now. |
SoftFever
approved these changes
Nov 8, 2024
|
Awesome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Screenshots/Recordings/Graphs
Tests