Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Tsmith35 per BS PR4631 (#6709)" #6845

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

tsmith35
Copy link
Contributor

Reverts #6709

This reverts the spiral lift modifications by @ziehmon for this reason:

unfortunately we need to revert this MR. There is a bug when AMS is used, since the position after changing filaments will be at X asis boundary and a spiral Z hop will move the axis out of physical boundaries. Details here: bambulab/BambuStudio#4841 (comment)

I am working on fixing this and will provide the fix here too. Sorry, I should've bought an AMS...

and additionally:

New PR: bambulab/BambuStudio#4848
Let's wait for review and testing. Will surely take some time, but at least that's fixed again...for now

The corrected spiral lift modification will be resubmitted once Bambu has completed testing their PR#4848.

Copy link
Owner

@SoftFever SoftFever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking care of this.

@SoftFever SoftFever merged commit 24ae14f into SoftFever:main Sep 20, 2024
15 checks passed
celtare21 added a commit to celtare21/OrcaSlicer that referenced this pull request Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants