Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve fuzzy skin with modifier #6759

Merged
merged 14 commits into from
Sep 22, 2024
Merged

Conversation

Noisyfox
Copy link
Collaborator

@Noisyfox Noisyfox commented Sep 14, 2024

Description

Now using fuzzy skin on modifiers no longer generate extra perimeters between regions.
Currently I only completed the code for classic wall mode. Arachne still work-in-progress.

Note: the algorithm can be slow with complicated models when using multiple modifiers (clipping and reconstructing polygons with lots of points can be computational intense), though it shouldn't slow down when using only one modifier compare to the original algorithm.

Fix #2647
Fix #5560

Screenshots/Recordings/Graphs

43d0b3f7816652ca49d68c9dd0336687
be0401d0b0ead3876077e29c97e668ed

@Noisyfox
Copy link
Collaborator Author

Noisyfox commented Sep 14, 2024

Currently there will be a seam when multiple modifiers with different fuzzy settings intersect:

image
image

Not sure how to fix this though.

@Noisyfox
Copy link
Collaborator Author

Noisyfox commented Sep 15, 2024

image
Somehow the modifier affects solid layers next to top/bottom layers. Weird...

Update: this issue is not caused by this PR though. This can be reproduced by adding a modifier with any option that does not affect the perimeters (such as the ironing option) on version 2.2.0beta as well.

Update 2: This issue should now be fixed with PR #6794

@Noisyfox Noisyfox marked this pull request as ready for review September 15, 2024 04:53
Copy link
Owner

@SoftFever SoftFever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks

@SoftFever SoftFever merged commit 9d3d242 into SoftFever:main Sep 22, 2024
15 checks passed
@vgdh
Copy link
Contributor

vgdh commented Sep 27, 2024

Wow. This is really great!

@northcoastam
Copy link

Great addition, thank you.

@dewi-ny-je
Copy link
Contributor

It would be nice if the same was done for speed modifiers: if I set a modifier to change perimeter speed for a part of an object, the modifier adds a surface (with all that comes with it, so changes of travel, lines are broken, ...) on the interface.

See this: https://3dprinting.stackexchange.com/questions/23331/how-to-change-print-speed-along-a-perimeter

image

Maybe check what caused the issue you solved just for fuzzy skin and solve it at the root?

@Noisyfox
Copy link
Collaborator Author

Noisyfox commented Oct 4, 2024

It would be nice if the same was done for speed modifiers: if I set a modifier to change perimeter speed for a part of an object, the modifier adds a surface (with all that comes with it, so changes of travel, lines are broken, ...) on the interface.

See this: https://3dprinting.stackexchange.com/questions/23331/how-to-change-print-speed-along-a-perimeter

image

Maybe check what caused the issue you solved just for fuzzy skin and solve it at the root?

That won't be easy, but I'll look at this when possible.

@irowboat
Copy link

While I'm not manually assigning modifiers, color painting creates them and I have no control over it; and if someone were to use beam interlocking, things get crazy as seen here: #5185 (comment)

Care to try that test case against your build?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FUZZY SKIN Fuzzy skin when blocked with modifier shows up as fuzzy line in model where edge of modifier is
6 participants