Support threshold overlap #6606
Open
+30
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nice! 👍Should get the QoL label. |
|
I thought about add absolute offset in addition to percent and reverse logic - i.e. use "overlap" instead of offset, though 15%/0.1mm means like this:
Probably it's more intuitive than setting 0.5mm/85%. |
vovodroid
force-pushed
the
support-threshold-offset-pr
branch
from
0cdca34
to
a1ffe88
Compare
That's absolutely correct! 😃 |
|
Offset replaced with overlap (line width - offset). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR unlocks and configure overhang offset support threshold in addition to angle threshold. Actually angle threshold has no intrinsic meaning, because it's offset which affects overhangs quality. Angle that could be printed without support is function of layer width and height.
This option sets percent of not supported external perimeter width triggering support
Width 0.62, layer 0.32, offset threshold 50%
Width 0.62, layer 0.32, offset threshold 80%
Width 0.62, layer 0.12, offset threshold 80%
So we don't need to adjust offset threshold when layer height is changed.