Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix input box widths in calibration UI #6587

Merged
merged 2 commits into from
Sep 23, 2024

Conversation

vvuk
Copy link
Contributor

@vvuk vvuk commented Aug 28, 2024

Description

A number of the input fields in the calibration panels are too small to show
the entire value, especially with the units. This PR takes into account
the size of the units and increases the width of the boxes. It's especially
an issue in the retraction test because the Step unit is very wide, and
then even worse on a high DPI display on Linux.

There's an additional issue that the dialogs are resizable but the panel
doesn't scale with the window, but that doesn't impact usability.

Screenshots/Recordings/Graphs

(Will attach shortly)

Tests

Opened all the panels.

Copy link
Owner

@SoftFever SoftFever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.
A few screenshots will be really helpful.

@vvuk
Copy link
Contributor Author

vvuk commented Sep 7, 2024

Whoops sorry, completely forgot. Here's the before and after for one of the dialogs, the others are the same. Note that in all cases the inner content doesn't scale up with the window either if the dialog window is resized (I resized the window manually in the "before" screenshot, but didn't do it in the "after"). I was going to fix that as well, but it's less of an issue.

before:
before

after:
after

Copy link
Owner

@SoftFever SoftFever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thank you

@SoftFever SoftFever merged commit 746a2bf into SoftFever:main Sep 23, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants