Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display Commit ID Used for Build in AboutDialog #6516

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Display Commit ID Used for Build in AboutDialog #6516

wants to merge 2 commits into from

Conversation

ElectricalBoy
Copy link
Contributor

An amended version of #6036.

Resolves #5935

@ElectricalBoy
Copy link
Contributor Author

ElectricalBoy commented Aug 20, 2024 •
edited
Loading

While I like the idea, I can't stand the text appears there -_-!
Maybe show it only for nightly build?

Originally posted by @SoftFever in #6036 (comment)

0e8cf86 now checks if there is a Git tag that points to the HEAD and enables commit ID display if there is no tag pointing to HEAD (i.e., is a nightly/snapshot build).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HappyPaul55 HappyPaul55 HappyPaul55 approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Build Info to About Dialog
2 participants
@ElectricalBoy @HappyPaul55