Shows extruder's values on filament's Setting Overrides tab. #6370
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The idea behind this PR is to make it easier for the users to tweak filament setting overrides i.e. reduce number of times users have to switch between the printer and filament settings to compare the values.
Screenshots/Recordings/Graphs
Tests
I've done some manual testing to confirm:
Other
I have discovered a strange behaviour between
Filament Settings
andPrinter Settings
windows. On a fresh load of application openingFilament Settings
window, navigating toSettings Overrides
tab and then closing the window results inFilament
tab being opened the next timeFilament Settings
window is opened. But if you openPrinter settings
window, navigate toExtruder
orMotion ability
tabs then the application changes the behaviour to open the last visited tab by the user for both of the windows. I'm mentioning this because when this happens the flow of events in the application changes and causes my change to break until the user changes a tab. As far as I can tell for some reason ConfigOptionsGroup'sreload_config
method is starting to get called (second time?) after TabFilament'supdate_filament_overrides_page
method which wipes out the values set by me. I'm not sure which is the correct behaviour, so I left that for a discussion here. If last visited tab is the correct behaviour, then I would need help to figure out how to fix this problem.