Unified pattern naming #6346
Open
Unified pattern naming #6346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kisslorand
force-pushed
the
Unified-pattern-naming
branch
4 times, most recently
from
58c9ccc
to
0145179
Compare
Unified pattern naming Unified pattern naming
kisslorand
force-pushed
the
Unified-pattern-naming
branch
from
0145179
to
aebf524
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR unifies the pattern naming used in the support settings to be aligned with the naming and style of the infill pattern ones.
Screenshots/Recordings/Graphs
Before:
After
Before:
After:
Tests
Compiled and tested in Win11.
Notes
With this PR "Rectilinear Grid" and "Rectilinear Interlaced" becomes obsolete as they were supposed to do the same as the regular "Rectilinear" used in sparse infill. "Aligned Rectilinear" used in sparse infill is added to the support pattern list as this style was already present in the pattern style but under the wrong name of "Rectilinear".