Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sidebar margin & spacing fixes #6238

Draft
wants to merge 14 commits into
base: main
Choose a base branch
from
Draft

Conversation

yw4z
Copy link
Contributor

@yw4z yw4z commented Jul 24, 2024

Fixes unequal spacings and margins on sidebar

Will keep this commit as draft for a while because i did this 2 month back and need to recheck code changes

Tried to control all spacings from a single file but that required more code changes because sidebar is split to 3 files (ParamsPanel.cpp, Plater.cpp, Tab.cpp)

This method only edits numbers for spacings and adds descriptions to them

TODO

• Aligning start point of combo boxes requires a bit fine tuning

IMPORTANT CHANGES TO CHECK

This changes should be check on high res monitors
• Parameters body text alignment src/slic3r/GUI/OG_CustomCtrl.cpp

Line 331 wxCoord h_pos = get_title_width() * m_em_unit + 4;

This line controls alignment of body text on parameters. basically added 4 to fix misalignment. static line element on titlebar using +5 and it looks on on my 2K monitor.

NOTES

Type Spacing Description
Titlebar Margin 8px Used as side margins on titlebar
Content Margin 12px Used as side margins contents of title
Icon Spacing 10px Used on main elements
Element Spacing 5px Used if elements has relation between them like edit button for combo box etc.

• Titlebar has less margin on sides to create separation with its content
• Spacings changing on multiple filaments while it creating second row for that section. Its an existing bug
• I didnt change margins for parameter titlebars because it creates too much wasted space

COMPARISON

Before After
Screenshot-20240724144320 copyasdas

Before After
Screenshot-20240724141913 Screenshot-20240724144333

ALIGNMENT PREVIEW

• I didnt change margins for parameter titlebars because it creates too much wasted space
Preview on %200 scale
Screenshot-20240724145205

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant