-
-
Notifications
You must be signed in to change notification settings - Fork 854
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flatpak Application TRACKING ISSUE #3949
Comments
@SoftFever I'm very sorry for pinging you, but I would like your "ok" on this. |
Hi @powpingdone First thing first, that's great! Could you please clarify what permission you are asking for? At the moment, Orca's CICD only creates appimages. |
I could do initial distribution of both nightly, and (eventually) stable releases past v2 (due to that flatpak patch needed) without using CI, but since I'm not the owner of the repository I would like your permission to operate this. |
I'm not asking you to submit a flatpak, I would be doing that myself (with input from you and other devs). |
Thanks for the explanation. Currently, all OrcaSlicer builds, including the official releases, are fully automated within this GitHub repository and it's CI/CD pipeline to ensure security. |
That's completely understandable. Shall I setup/pr a CI job to distribute a flatpak then? I would have to give you a key as a secret to allow uploading to flathub. |
👍 |
+1. Good initiative. There are a lot of Linux distros that will appreciate. |
Note to self, from the flatpak matrix
|
this is great! can we not wait for 2.0 and just have one for 1.9 already? |
@tapir afaict, because of the flatpak specific patches, no. |
That manifest looks eerily familiar ;) Let me know if you think there's anything we could do to make it easier to share between the 2 manifests repositories, once this has landed, and please CC: me on the Flathub review as well. |
shhhh I totally didn't do anything to it :P |
so as it happens i just opened the orcaslicer github page to check if there was a release for 2.0 since bambustudio messed up some tree supports. 6 minutes ago was the release of 2.0, i am in luck. since this is an open source project and devs are always very interested in annoying and pushy comments i thought i would do my part and ask: why is there no flatpak released 6 minutes after the official release? i cant believe it. seriously though, what is the process and how can we help? is this already implemented and the pipeline is just slower (6 minutes, i mean cmon ... :D)? thanks for all your great work! |
@kugelzucker currently i'm bogged down by irl stuff and ci is failing for reasons unknown (when it was previously fine). |
im giving this a nudge, checking in |
also, this builds and installs fine for me. fyi (and yes i know that CI is different ;)) |
@kugelzucker tl;dr: this messes with a lot of dep resolution stuff so it gets messy on other systems. it's fine for flatpak, but it's not fine for literally everyone else |
Update for everyone who is following this but not the PR: #4175 has been merged. Next up, Softfever and I will have to get in contact with Flathub to get the necessary things (api keys) to upload from CI. |
cc #5449 |
cc #5474 |
I'd also like to note that you may want to build the flatpak with freedesktop-22.08 rather than gnome-45, as freedesktop prioritizes having applications work consistently on all platforms rather than one. I also noticed in my testing that building with freedesktop causes the flatpak to have a slightly smaller size and uses less ram than the gnome build. |
@hgelpke cross quoting from pr:
tldr: |
Great! Thanks for the reply and apologies for missing it. Good luck on the fix and I appreciate your efforts |
Ok, after the cmake fiasco we're now in the tree. Finally. Going to file an issue to flathub soon(tm). |
P1S camera still not working Flatpak 2.1.1 Build all #2600 PS: Also testing the official bambulab studio and the camera works. |
https://discourse.flathub.org/t/orcaslicer-requesting-external-upload-to-flathub/7340 @SoftFever (also @hadess because I don't know where to go with this situation). |
Does this have to be fully automated through CI @SoftFever? What if flathub doesn't want to do an external upload? |
Is there an issue with letting Flathub build the flatpak themselves? The build process and configuration is identical to what is already in the Github Actions CI. Flatpak builds can continue to run in Github Actions CI as an internal testing step, but I think it's likely important for security reasons that Flathub is able to build from source, which is why they have policies around what kinds of builds can be submitted. |
Looks like the issue on flathub side was closed due to inactivity. I'd like to take this over if possible but I, 100%, agree with @JustinLex, I don't see any reason to not follow flathub standards. Are we missing something @powpingdone? |
@tapir no it's just been me being incredibly busy. I'll make the flathub issue proper (not discourse). |
I misread your comment, sorry. @SoftFever why can't we have flathub building the flatpak for orcaslicer externally? |
This would make distribution a lot easier because you can just git submodule the |
@SoftFever bump, waiting for your input. |
Has anyone got working flatpak of 2.2? |
I don't mean to be that person, but do you know when we could get a working GitHub action for the flatpak? |
@SoftFever sorry for nagging you, but could we please get an approval for building flatpak externally? It would simplify installation of Orca Slicer for a lot of Linux users and personally I don't see any drawbacks for you, only benefits. Flatpak runtime environment is more contained than any Linux distro, so Orca Slicer will be running more stable and it would be easier to reproduce bugs if there are any. |
@anarsoul Correct me if I'm wrong but as far as I understand under AGPL-3.0 licence distribution of the software is allowed as you disclose source and use the same licence as original. |
@Ziomal12 see flathub submission guide: https://docs.flathub.org/docs/for-app-authors/submission/#theres-an-app-that-id-like-to-see-on-flathub-but-im-not-the-developer We are at the step one. Submitting it without author's approval is the last resort. |
@anarsoul Try emailing or DM on X. Notification is probably just not getting through or lost in everything else going on. |
@ChaosBlades |
@cochcoder we haven't heard from him on this thread since Aug. That's probably what @ChaosBlades meant. |
I created a repo with (fixed) flatpak manifest for OrcaSlicer: https://github.com/anarsoul/io.github.softfever.OrcaSlicer Flatpak for v2.2.0 can be found here: https://github.com/anarsoul/io.github.softfever.OrcaSlicer/releases/tag/v2.2.0-1 |
Do you think you'll be able to make a PR with the manifest fixes? |
@cochcoder I can, although it won't help with getting flatpak into flathub. One of the fixes has been sitting in review for 3 weeks: #7057 The other fix is getting rid of python script and integrating dark theme detection into wxWidgets (see the patch in my repo, I took it from bambulab slicer manifest repo) |
That's fine, we would've need to get a working flatpak first anyways.
You could link to those in your PR and mention that they need to get merged alongside the manifest fixes. |
This is what the build fixes that go into Bambu Studio look like: If the OrcaSlicer devs are anything like me, they're probably expecting better commit messages.
You're welcome ;) |
It's not my PR, but if OrcaSlicer devs were anything like me, they'd probably fix up commit message if they don't like it and merge the PR :) |
This is a tracking issue for the flatpak build of orcaslicer, as there are a few specific bugs that must be fixed in order to consider the build working properly.
Original Issue Description
I am requesting permission to create a Flatpak application (manifest here), along with any modifications required by other contributors. Given permission, I will go on to flathub and publish the application.
The text was updated successfully, but these errors were encountered: