[Do not merge] Simulated upgrade test for mainnet Gateway contract #1279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Improve PNA implementation * More improvents to ERC20 token * Fix implementation of Assets._sendForeignToken * Fix build payload for foreign token --------- Co-authored-by: ron <[email protected]>
vgeddes
changed the title
vgeddes
changed the title
yrong
reviewed
Sep 1, 2024
Comment on lines
+78
to
+79
| /// Mock call to Verification.verifyCommitment to bypass BEEFY verification | ||
| vm.mockCall(VERIFICATION_ADDR, abi.encodeWithSelector(Verification.verifyCommitment.selector), abi.encode(true)); |
There was a problem hiding this comment.
Cool! Another option is to use vm.startPrank(GatewayProxy) and test upgrade function directly. cf596f3
vgeddes
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses Foundry's ability to run tests using storage forked from production networks.
Requirements:
MAINNET_RPC_URLto environment (I've updated Github Actions to include this secret)Tasks