-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transact from sub to eth #1145
base: bridge-next-gen
Are you sure you want to change the base?
Transact from sub to eth #1145
Changes from 18 commits
fe7a814
89c9e3f
5823492
00c5eed
ebc8986
3d18d1a
8ceb5ee
42f9e07
0a8dc1e
69305f8
bd88ed8
f6beeb1
add22c2
9019ab4
1fb852d
b89cc6c
606e867
539c180
fe513c7
7880d46
27c14e9
14a40cf
0510064
c3b7817
b7e85ca
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -82,3 +82,15 @@ struct SetPricingParametersParams { | |
/// @dev Fee multiplier | ||
UD60x18 multiplier; | ||
} | ||
|
||
// Payload for TransactCall | ||
struct TransactCallParams { | ||
/// @dev The agent ID of the consensus system | ||
bytes32 agentID; | ||
/// @dev The target contract | ||
address target; | ||
/// @dev Payload of the call | ||
bytes payload; | ||
/// @dev Max gas cost of the call | ||
uint64 dynamicGas; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The message packet already has a The gas estimator on BridgeHub should add a buffer to There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, it's the same thing. Just rename it for less confusion. |
||
} |
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -35,6 +35,8 @@ interface IGateway { | |||||
// Emitted when funds are withdrawn from an agent | ||||||
event AgentFundsWithdrawn(bytes32 indexed agentID, address indexed recipient, uint256 amount); | ||||||
|
||||||
event TransactExecuted(bytes32 indexed agentID, address indexed target, bytes payload); | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||||||
|
||||||
/** | ||||||
* Getters | ||||||
*/ | ||||||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
params.payload
could be very large, cheaper to hash it when emitting eventThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
7880d46