Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate bindings once for all platforms and architectures #67

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

ids1024
Copy link
Member

@ids1024 ids1024 commented Jan 16, 2024

Based on the CI in Smithay/drm-rs#176.

libinput_log_set_handler is disabled, since it requires va_list. That doesn't seem practical to support until std::ffi::VaList is stable.

I don't think BSDs should be different here, but I haven't tested it yet. CI confirms that the bindings are the same on Linux for tested architectures.

Based on the CI in
Smithay/drm-rs#176.

`libinput_log_set_handler` is disabled, since it requires `va_list`.
That doesn't seem practical to support until `std::ffi::VaList` is
stable.

I don't think BSDs should be different here, but I haven't tested it
yet. CI confirms that the bindings are the same on Linux for tested
architectures.
@ids1024
Copy link
Member Author

ids1024 commented Jan 17, 2024

I've now tested on FreeBSD (x86_64). The same bindings are generated.

Copy link
Member

@Drakulix Drakulix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Drakulix Drakulix merged commit 7f83b83 into Smithay:master Jan 17, 2024
15 checks passed
@Drakulix Drakulix mentioned this pull request Jan 17, 2024
@ids1024 ids1024 mentioned this pull request Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants