Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add riscv64gc target #60

Merged
merged 1 commit into from
Oct 24, 2023
Merged

Add riscv64gc target #60

merged 1 commit into from
Oct 24, 2023

Conversation

Vixea
Copy link
Contributor

@Vixea Vixea commented Oct 23, 2023

a little personal project of mine requires support for RISC-V

@Vixea Vixea marked this pull request as draft October 23, 2023 07:35
@Vixea
Copy link
Contributor Author

Vixea commented Oct 23, 2023

one thing that needs addressing is the rest of the ci

@Vixea
Copy link
Contributor Author

Vixea commented Oct 24, 2023

just decided to skip the ci maybe @katyo can try CI is not my forte.

@Vixea Vixea marked this pull request as ready for review October 24, 2023 03:24
@Drakulix
Copy link
Member

Can you please run the generated files through cargo fmt

@Vixea
Copy link
Contributor Author

Vixea commented Oct 24, 2023

yep, I noiced no changes when running cargo fmt

@Drakulix
Copy link
Member

yep, I noiced no changes when running cargo fmt

Well every other platform is formatted, please figure this out, this makes it completely impossible to inspect the files for basic functionality.

@Vixea
Copy link
Contributor Author

Vixea commented Oct 24, 2023

done manually with rustfmt. idk but it seems like cargo fmt broke for me, idk

@Vixea
Copy link
Contributor Author

Vixea commented Oct 24, 2023

and got drm-rs done while I was at this, review whenever you want

Copy link
Member

@Drakulix Drakulix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Drakulix Drakulix merged commit 83e5754 into Smithay:master Oct 24, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants