Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

channel: Return PostAction::Remove on disconnect #208

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

ids1024
Copy link
Member

@ids1024 ids1024 commented Sep 6, 2024

It seems 86c6713 broke this. By maintaining a copy of Ping, the ping source will never return PostAction::Remove.

(I guess we could use more tests to catch things like this...)

It seems 86c6713 broke this. By maintaining a copy of `Ping`, the ping
source will never return `PostAction::Remove`.
Copy link

codecov bot commented Sep 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.22%. Comparing base (5ba1370) to head (2f398bc).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #208      +/-   ##
==========================================
+ Coverage   85.44%   86.22%   +0.77%     
==========================================
  Files          13       15       +2     
  Lines        1876     2069     +193     
==========================================
+ Hits         1603     1784     +181     
- Misses        273      285      +12     
Flag Coverage Δ
macos-latest 85.50% <100.00%> (?)
ubuntu-latest 85.82% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@notgull notgull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@notgull notgull merged commit 8d11455 into Smithay:master Sep 6, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants