Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a SlimefunItem constructor that only needs ItemGroup and SlimefunItemStack #4179

Conversation

ProfElements
Copy link
Contributor

@ProfElements ProfElements commented Apr 29, 2024

Description

I have a seperate system of managing recipes and would like a shorthand to not have to define them at item creation time.

Proposed changes

Add a SlimefunItem constructor that just passed RecipeType.NULL and empty recipe for its recipe and input fields.

Related Issues (if applicable)

Checklist

  • I have fully tested the proposed changes and promise that they will not break everything into chaos.
  • I have also tested the proposed changes in combination with various popular addons and can confirm my changes do not break them.
  • I have made sure that the proposed changes do not break compatibility across the supported Minecraft versions (1.16.* - 1.20.*).
  • I followed the existing code standards and didn't mess up the formatting.
  • I did my best to add documentation to any public classes or methods I added.
  • I have added Nonnull and Nullable annotations to my methods to indicate their behaviour for null values
  • I added sufficient Unit Tests to cover my code.

@ProfElements ProfElements requested a review from a team as a code owner April 29, 2024 03:30
Copy link
Contributor

Pro Tip!
You can help us label your Pull Requests by using the following branch naming convention next time you create a pull request. ❤️

Branch naming convention Label
feature/** 🎈 Feature
fix/** ✨ Fix
chore/** 🧹 Chores
api/** 🔧 API
performance/** 💡 Performance Optimization
compatibility/** 🤝 Compatibility

If your changes do not fall into any of these categories, don't worry. You can just ignore this message in that case! 👀

@ProfElements ProfElements changed the title ❇️ feat(SlimefunItem): Add constructor that takes ItemGroup Add a SlimefunItem constructor that only needs ItemGroup and SlimefunItemStack Apr 29, 2024
Copy link
Contributor

Slimefun preview build

A Slimefun preview build is available for testing!
Commit: 8430677f

https://preview-builds.walshy.dev/download/Slimefun/4179/8430677f

Note: This is not a supported build and is only here for the purposes of testing.
Do not run this on a live server and do not report bugs anywhere but this PR!

Copy link
Contributor

@JustAHuman-xD JustAHuman-xD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, don't see a reason not to

Copy link
Member

@TheBusyBiscuit TheBusyBiscuit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TheBusyBiscuit TheBusyBiscuit merged commit d25f224 into Slimefun:master Aug 8, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants