BUG: Fix editing of transform component values in spinbox #7942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
finetjul
reviewed
Sep 18, 2024
Contains a single additional commit: Revision: 76e21221f81a4483d58f99a4d63d76f13718fb57 Author: Andras Lasso <[email protected]> Date: 2024-09-18 10:50:22 AM Message: ENH: Add method to check if double-spinbox value is being edited (Slicer#1219)
In Transforms module, when rotate-first mode was enabled and edited translation components and the number of digits changed, the value that was being edited was reset. The problem was that when number of digits change then sibling widgets get a notification and they update their number of digits, too, which results in value change, which leads to resetting of all values (including the one that is being edited). Fixed by preventing resetting of the slider+spinbox for the axis that is being edited using the spinbox. fixes Slicer#7574
lassoan
force-pushed
the
fix-transform-editing-via-spinbox
branch
from
3e59d26
to
71abfd4
Compare
For future reference, see commontk/CTK@627842c...76e2122 |
|
I am building & testing locally ⏳ |
|
Local testing was ✅ Improvement of In the meantime, I will bypass the check and move forward with the integration 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Transforms module, when rotate-first mode was enabled and edited translation components and the number of digits changed, the value that was being edited was reset. The problem was that when number of digits change then sibling widgets get a notification and they update their number of digits, too, which results in value change, which leads to resetting of all values (including the one that is being edited). Fixed by preventing resetting of the slider+spinbox for the axis that is being edited using the spinbox.
fixes #7574
Draft pull request because it requires merging of commontk/CTK#1219required CTK update was merged and git hash is updated in this pull request