Update check_description_files script and fix s4ext files #2029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcfr
force-pushed
the
tweak-check_description_files-script-and-fix-s4ext-files
branch
from
cce9fcd
to
873fadd
Compare
Add missing metadata keys: contributors, description, homepage, iconurl, screenshoturls Update invalid homepage value Remove extra spaces in screenshoturls list
Use direct link to the corresponding image instead of link of the form `http://www.slicer.org/wiki/File:ImageName.png`. Use `https://www.slicer.org/slicerWiki/images` URL base instead of invalid `http://www.slicer.org/w/images`. Use `https://www.na-mic.org/w/img_auth.php` URL base instead of invalid `http://wiki.na-mic.org/Wiki/images`.
Add `--check-urls-reachable` CLI option
jcfr
force-pushed
the
tweak-check_description_files-script-and-fix-s4ext-files
branch
from
8c9960e
to
91560e6
Compare
Use `https://www.slicer.org/slicerWiki/images` URL base instead of invalid `https://www.slicer.org/w/images`.
…tration.000webhostapp.com
jcfr
force-pushed
the
tweak-check_description_files-script-and-fix-s4ext-files
branch
from
91560e6
to
0ccd10e
Compare
* Fix use of GitHub raw links for screenshoturls associated with these extensions: - iGyne - mpReview - SurfaceWrapSolidify * SNRMeasurement: Switch to using existing URL instead of placeholder one * RegistrationQA: Switch to using screenshot from repository instead of placeholder URL. * SlicerOpenAnatomy: Use updated URLs to account for extension re-organization See PerkLab/SlicerOpenAnatomy@7bab080f7 * CarreraSlice: Fix URL prefix using `www.na-mic.org/w/img_auth.php` instead of unsupported `www.na-mic.org/Wiki/images/thumb` * OpenDose3D: Update URLs to account for rename from `Dosimetry4D` to `OpenDose3D`
* SlicerZFrameRegistration: Use https://github.com/SlicerProstate/SlicerZFrameRegistration instead of non-existent https://slicer.org/slicerWiki/index.php/Documentation/Nightly/Extensions/ZFrameRegistration * Switch to using link to README instead of non-existent Slicer wiki page: - ResectionPlanner - SlicerSkinMouldGenerator - SNRMeasurement * PETCPhantom: Switch to using existing wiki page associated with PETCPhantomAnalysis module.
Considering maintainers have been unresponsive[^1], switch to using @jamesobutler fork. [^1]: AldrickF/SlicerRegularizedFastMarching#2
Regression liked introduced in pieper/SlicerParallelProcessing@7e8401d90 (Rename extension from SlicerProcesses to ParallelProcessing)
Follow-up of Slicer#1525 (comment) and gsi-biomotion/SlicerRegistrationQA@5a75daff5 (Changed names, added description, debug)
This is expected to address the following: ``` $ python ./scripts/check_description_files.py \ --check-urls-reachable \ AstmPhantomTest.s4ext SlicerIGT.s4ext [...] AstmPhantomTest.s4ext homepage is 'https://www.atracsys-measurement.com/astm/': The read operation timed out SlicerIGT.s4ext homepage is 'https://www.slicerigt.org': The read operation timed out Checked content of 2 description files. Total errors found in extension descriptions: 2 ```
jcfr
force-pushed
the
tweak-check_description_files-script-and-fix-s4ext-files
branch
from
acb9fc5
to
bd8f866
Compare
…pository-name Following 553c045 ("CI: Update check_git_repository_name hard-coding exceptions", 2024-03-12), exceptions are hard-coded and there is no need to run the check only for new files.
jcfr
force-pushed
the
tweak-check_description_files-script-and-fix-s4ext-files
branch
from
bd8f866
to
d7e8ea5
Compare
jcfr
force-pushed
the
tweak-check_description_files-script-and-fix-s4ext-files
branch
from
a990fe1
to
67c5205
Compare
jcfr
deleted the
tweak-check_description_files-script-and-fix-s4ext-files
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before moving forward with the transition from
.s4extto.json, we are following these steps:.s4extfilesCMakeLists.txtin each extension GitHub repository with the correct valuesThis pull request corresponds to the first step.
Remaining updates for step 1:
homepageURL to use httpsiconurlURL to use httpsscreenshoturlsto use httpscheck_description_filesto check URLs are reachable--check-urls-reachableRelated pull requests: