Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tweak CI updating pre-commit settings #2018

Merged
merged 3 commits into from
Mar 19, 2024
Merged

Tweak CI updating pre-commit settings #2018

merged 3 commits into from
Mar 19, 2024

Conversation

jcfr
Copy link
Member

@jcfr jcfr commented Mar 19, 2024 •
edited
Loading

  • Update pre-commit settings adding "check-yaml" and "debug-statements"
  • Reformat yml files using prettier
  • Update pre-commit settings to run prettier on yml and json files

Changes done anticipating the integration of:

@jcfr
CI: Update pre-commit settings adding "check-yaml" and "debug-stateme…
3478263 
…nts"

* check-yaml: Attempts to load all yaml files to verify syntax.
  See https://github.com/pre-commit/pre-commit-hooks#check-yaml

* debug-statements: Check for debugger imports and py37+ breakpoint() calls in python source.
  See https://github.com/pre-commit/pre-commit-hooks#debug-statements
@jcfr
STYLE: Reformat yml files using prettier
5d6f873 
This commit updates the yml files based on the automatic fixes
applied using the prettier introduced in the subsequent commit.
@jcfr
CI: Update pre-commit settings to run prettier on yml and json files
eec61d8 
See https://github.com/pre-commit/mirrors-prettier
and https://prettier.io/docs/en/
@jcfr jcfr merged commit 69b2237 into Slicer:main Mar 19, 2024
4 checks passed
@jcfr jcfr deleted the tweak-ci branch March 19, 2024 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jcfr